The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 27, 2026 5:40pm

PR Summary

Medium Risk
Tightens authorization and adds token-binding on upload and copilot endpoints; risk is moderate because stricter checks and new required parameters/tokens can break existing callers and block previously-allowed operations if assumptions were incorrect.

Overview
Security hardening across uploads and copilot tools to prevent IDORs. Multipart upload now requires workspaceId + workspace write/admin permission at initiation, returns an HMAC-signed short-lived uploadToken, and all follow-up actions (get-part-urls, complete, abort) derive uploadId/key/context from the verified token (with an allowlist of valid StorageContexts) instead of trusting client input.

Copilot tools now enforce workspace-scoped access before mutating or returning data: credential rename/delete is gated via getCredentialActorContext; restore operations validate the target resource’s workspace and require write/admin; workflow folder move/rename validates folder ownership via new verifyFolderWorkspace; job logs queries require workspace context and filter by workspaceId; knowledge-base and user-table tools add explicit read/write checks to prevent cross-workspace access.

^{Reviewed by Cursor Bugbot for commit 3f7a3ba. Configure here.}

Greptile Summary

This PR patches a set of IDOR and missing-authorization vulnerabilities across the multipart upload API and a wide range of copilot tool handlers. The multipart upload fix is particularly well-designed: sessions are now bound to a short-lived HMAC-SHA256-signed token (uploadId + key + userId + workspaceId + context) issued only after a workspace write-permission check, and all follow-up actions source their context exclusively from the verified token rather than trusting the client.

The copilot handler fixes are comprehensive — knowledge-base (11 ops), user-table (6 ops), manage-credential, restore-resource, folder move/rename, and get-job-logs are all gated with appropriate access checks. The logic throughout is consistently fail-closed. The only minor concern is the fixed 1-hour upload-token TTL, which could cause token expiry for very large uploads before the session completes.

Confidence Score: 5/5

Safe to merge — all IDORs are patched with fail-closed logic and no new regressions introduced

No P0 or P1 findings. The security fixes are correct and comprehensive; the only open item is a P2 TTL concern for very large uploads. Previous review threads confirm earlier edge cases (split limit, log count) were addressed in a prior commit.

No files require special attention; upload-token.ts TTL default is worth a second look if multi-hour large file uploads are a real-world scenario

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant C as Client
    participant API as Multipart API
    participant Auth as Workspace ACL
    participant Token as HMAC Signer
    participant Store as Cloud Storage

    C->>API: initiate {fileName, workspaceId, context}
    API->>Auth: check write permission
    Auth-->>API: allowed
    API->>Store: start upload session
    Store-->>API: uploadId + path
    API->>Token: sign session payload (1h TTL)
    Token-->>API: uploadToken
    API-->>C: uploadId, path, uploadToken

    C->>API: get-part-urls {uploadToken, partNumbers}
    API->>Token: verify token + userId
    Token-->>API: session payload
    API->>Store: generate presigned part URLs
    API-->>C: presignedUrls

    C->>Store: PUT chunks via presigned URLs

    C->>API: complete {uploadToken, parts}
    API->>Token: verify token + userId
    Token-->>API: session payload
    API->>Store: finalize upload
    API-->>C: success + location

_{Reviews (3): Last reviewed commit: "fix(security): close folder workspace by..." | Re-trigger Greptile}

@greptile

@cursor review

@greptile

@cursor review